mmdetection
mmdetection copied to clipboard
[Fix] Fixed MMDetWandbHook to operate on no-mask COCO
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
MMDetWandbHook induce error when I used no-mask COCO dataset. (custom COCO dataset which I made)
Modification
I set default value of masks to [None]
, which is similar to COCO's no-mask mask [None, None, ...]
. Since single None value of masks can mean masks is not well-formed, I discriminated usage of mask by checking masks[0] is not None
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
- Pre-commit or other linting tools are used to fix the potential lint issues.
- The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
- If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
- The documentation has been modified accordingly, like docstring or example tutorials.