mmdetection icon indicating copy to clipboard operation
mmdetection copied to clipboard

[Enhance] Filter out bboxes out of scale range in test-time augmentation.

Open jbwang1997 opened this issue 2 years ago • 1 comments

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Filter out bboxes out of scale range in test-time augmentation.

Modification

Add a new key named obj_range in test-time augmentation. Filter out bboxes by areas in merge_aug_bboxes. Release dyhead model with tta.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

jbwang1997 avatar May 16 '22 01:05 jbwang1997

Codecov Report

Merging #7993 (f4a816b) into dev (7b03639) will decrease coverage by 0.00%. The diff coverage is 17.39%.

:exclamation: Current head f4a816b differs from pull request most recent head 1ab0f1a. Consider uploading reports for the commit 1ab0f1a to get more accurate results

@@            Coverage Diff             @@
##              dev    #7993      +/-   ##
==========================================
- Coverage   64.49%   64.48%   -0.01%     
==========================================
  Files         360      360              
  Lines       29233    29251      +18     
  Branches     4954     4957       +3     
==========================================
+ Hits        18854    18863       +9     
- Misses       9373     9383      +10     
+ Partials     1006     1005       -1     
Flag Coverage Δ
unittests 64.46% <17.39%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/dense_test_mixins.py 38.04% <0.00%> (-5.17%) :arrow_down:
mmdet/datasets/pipelines/test_time_aug.py 88.67% <50.00%> (-6.98%) :arrow_down:
mmdet/models/roi_heads/mask_heads/maskiou_head.py 89.65% <0.00%> (+2.29%) :arrow_up:
mmdet/core/bbox/assigners/sim_ota_assigner.py 83.63% <0.00%> (+3.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b03639...1ab0f1a. Read the comment docs.

codecov[bot] avatar May 16 '22 01:05 codecov[bot]