mmdetection icon indicating copy to clipboard operation
mmdetection copied to clipboard

[Fix] support replacing data_root in list (like ConcatDataset)

Open troyliu0105 opened this issue 2 years ago • 3 comments

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Current update_data_root function do not handle list field. So the this function do not work for some datasets like ConcatDataset etc.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

troyliu0105 avatar Apr 11 '22 10:04 troyliu0105

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 11 '22 10:04 CLAassistant

LGTM

Czm369 avatar Apr 13 '22 03:04 Czm369

@troyliu0105 Thank you very much for your contribution. Can you add a unit test for this function? This is important. Thank you.

hhaAndroid avatar Apr 20 '22 11:04 hhaAndroid