mmdetection icon indicating copy to clipboard operation
mmdetection copied to clipboard

Automatic validation of your citation metadata

Open abelsiqueira opened this issue 3 years ago • 4 comments

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Hello!

We noticed that your repository is using the Citation File Format to store citation metadata in CITATION.cff. This Pull Request automates validation of that file using the cffconvert GitHub Action. That way, it's a little bit easier to be robust against future changes to the CITATION.cff file.

BTW it's perfectly fine if you don't feel like accepting this Pull Request for whatever reason -- we just thought it might be helpful is all.

We found your repository using a partially automated workflow; if you have any questions about that, feel free to create an issue over at https://github.com/cffbots/filtering/issues/

On behalf of the cffbots team, @abelsiqueira / @fdiblen / @jspaaks

Modification

Add cffconvert.yml to validate CITATION.cff

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

abelsiqueira avatar Feb 07 '22 15:02 abelsiqueira

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 07 '22 15:02 CLAassistant

Codecov Report

Patch has no changes to coverable lines.

:loudspeaker: Thoughts on this report? Let us know!.

codecov[bot] avatar Feb 08 '22 03:02 codecov[bot]

@abelsiqueira Thanks for your contribution, please fix the lint.

hhaAndroid avatar Feb 11 '22 03:02 hhaAndroid

I have rebased into the current master and it passes the lint check locally and in our fork: https://github.com/cffbots/mmdetection/actions/runs/1839863997

abelsiqueira avatar Feb 14 '22 08:02 abelsiqueira

Hi @abelsiqueira!We are grateful for your efforts in helping improve this open-source project during your personal time. Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) Thank you again for your contribution❤ @abelsiqueira

OpenMMLab-Assistant003 avatar Apr 14 '23 02:04 OpenMMLab-Assistant003