mmdetection icon indicating copy to clipboard operation
mmdetection copied to clipboard

[unify] change train_detector to train_model

Open EasonQYS opened this issue 3 years ago • 4 comments

change function name train_detector to train_model, same as other mmlab api style.

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

To be same as other mmlab api style.

Modification

change function name train_detector to train_model, same as other mmlab api style.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

EasonQYS avatar Jan 29 '22 07:01 EasonQYS

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 29 '22 07:01 CLAassistant

@EasonQYS Thank you for your submission! Please sign CLA at first.

hhaAndroid avatar Jan 29 '22 07:01 hhaAndroid

Thanks for reminding me.

EasonQYS avatar Jan 29 '22 08:01 EasonQYS

Codecov Report

Patch coverage is 1.85% of modified lines.

Files Changed Coverage
mmdet/apis/train.py 1.85%

:loudspeaker: Thoughts on this report? Let us know!.

codecov[bot] avatar Feb 09 '22 10:02 codecov[bot]