mmdetection icon indicating copy to clipboard operation
mmdetection copied to clipboard

Update video_demo.py

Open GuangjiHuang opened this issue 3 years ago • 2 comments

  1. wait-time is the wrong name of the variable;

  2. the cv.waitKey's parameter delay must be the interger intead of the float datatype.

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

GuangjiHuang avatar Dec 08 '21 13:12 GuangjiHuang

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 08 '21 13:12 CLAassistant

.

GuangjiHuang avatar Dec 08 '21 13:12 GuangjiHuang

Hi @GuangjiHuang!We are grateful for your efforts in helping improve this open-source project during your personal time. Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) Thank you again for your contribution❤ @GuangjiHuang

OpenMMLab-Assistant003 avatar Apr 12 '23 08:04 OpenMMLab-Assistant003