mmdeploy
mmdeploy copied to clipboard
improvement(cmake): simplify build option and doc
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Build option is too complex for me.
Now that I have specified ncnn_DIR=xx
, why have I typing TARGET_BACKENDS=ncnn
...
If you want to use ncnn, cmake -Dncnn_DIR=${NCNN_DIR}/build/install/lib/cmake/ncnn ..
should be all you need.
Please first review https://github.com/open-mmlab/mmdeploy/pull/842
Modification
- Remove repeated
MMDEPLOY_TARGET_BACKENDS
option - Remove redundant build option description in doc, add a
cmake_option.md
- Using
g++-7
if g++ compiler not specified - Update doc
Checklist
- Pre-commit or other linting tools are used to fix the potential lint issues.
- The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
- If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
- The documentation has been modified accordingly, like docstring or example tutorials.
Codecov Report
Merging #832 (9d640d0) into master (f80c90e) will not change coverage. The diff coverage is
n/a
.
:exclamation: Current head 9d640d0 differs from pull request most recent head b345756. Consider uploading reports for the commit b345756 to get more accurate results
@@ Coverage Diff @@
## master #832 +/- ##
=======================================
Coverage 54.65% 54.65%
=======================================
Files 280 280
Lines 9289 9289
Branches 1349 1349
=======================================
Hits 5077 5077
Misses 3858 3858
Partials 354 354
Flag | Coverage Δ | |
---|---|---|
unittests | 54.65% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
May be still need change jetsons.md to remove -DMMDEPLOY_TARGET_BACKENDS
options explicitly.
The same about zh-cn version.
May update the building way of the dockerfile as well.
May update the building way of the dockerfile as well.
done.
Please fix CircleCI first, and then LGTM.
done.