mmcv icon indicating copy to clipboard operation
mmcv copied to clipboard

Published 20 hours ago • verified publisher icon open-mmlab

[Feature]: Add the support of op "MinAreaPolygons" for ascend device

Open long11111111 opened this issue 2 years ago • 3 comments

Type：Feature Team：PyTorch_Ops_Dev InventoryUpdate：NO Issue：NA Description： Add the adaptation file for the operator "MinAreaPolygons"

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • [ ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • [ ] CLA has been signed and all committers have signed the CLA in this PR.

long11111111 avatar Feb 21 '23 03:02 long11111111

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 21 '23 03:02 CLAassistant

Add the unit test.

ckirchhoff2021 avatar Feb 28 '23 08:02 ckirchhoff2021

Hi @long11111111 ！We are grateful for your efforts in helping improve this open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA If you have a WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）

Thank you again for your contribution❤

OpenMMLab-Assistant001 avatar Apr 13 '23 03:04 OpenMMLab-Assistant001