mmcv icon indicating copy to clipboard operation
mmcv copied to clipboard

[Fix]Optimize the display effect of ProgressBar.update()

Open 5ampere opened this issue 3 years ago • 2 comments

Motivation

The display effect of 'ETA' and 'elapsed' during the eval is not intuitive, like 48970s. This pull request makes their display the same as that during training, like 4:13:59

Modification

Modified mmcv->utils->progressbar.py->ProgressBar->updata->msg

BC-breaking (Optional)

None

Use cases (Optional)

None

Checklist

Before PR:

  • [x] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [x] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [x] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [x] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [x] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • [ ] CLA has been signed and all committers have signed the CLA in this PR.

5ampere avatar Sep 20 '22 04:09 5ampere

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 20 '22 04:09 CLAassistant

I found unit_ Tests failed. Should I change mmcv\tests\test_utils\test_progressbar.py to fit this change?

5ampere avatar Sep 20 '22 06:09 5ampere

I found unit_ Tests failed. Should I change mmcv\tests\test_utils\test_progressbar.py to fit this change?

Thanks for your contribution! I think it is ok to modify the old unit test

HAOCHENYE avatar Sep 29 '22 10:09 HAOCHENYE

It could be better to show the difference of the old progress bar and the new one in the PR message

HAOCHENYE avatar Oct 01 '22 05:10 HAOCHENYE

It could be better to show the difference of the old progress bar and the new one in the PR message

I modified my PR message, is that OK?

5ampere avatar Oct 01 '22 06:10 5ampere

I found unit_ Tests failed. Should I change mmcv\tests\test_utils\test_progressbar.py to fit this change?

LGTM, approved! BTW, providing a picture may be better to understand :rofl:

HAOCHENYE avatar Oct 01 '22 15:10 HAOCHENYE

I found unit_ Tests failed. Should I change mmcv\tests\test_utils\test_progressbar.py to fit this change?

LGTM, approved! BTW, providing a picture may be better to understand 🤣

I added two pictures, which look much better. BTW, what else should I do to get PR through?

5ampere avatar Oct 02 '22 02:10 5ampere

Sorry for my late reply (we were on vacation :rofl:)! we'll merge this PR ASAP!

HAOCHENYE avatar Oct 08 '22 07:10 HAOCHENYE

Sorry for my late reply (we were on vacation 🤣)! we'll merge this PR ASAP!

Never mind, I was on vacation too. BTW, thanks for your guidance, this is my first PR.

5ampere avatar Oct 17 '22 08:10 5ampere

Sorry for my late reply (we were on vacation rofl)! we'll merge this PR ASAP!

Never mind, I was on vacation too. BTW, thanks for your guidance, this is my first PR.

Looking forward to your second one! image

HAOCHENYE avatar Oct 17 '22 09:10 HAOCHENYE

Hi @5ampere !We are grateful for your efforts in helping improve this open-source project during your personal time. Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) Thank you again for your contribution❤

OpenMMLab-Assistant005 avatar Apr 11 '23 14:04 OpenMMLab-Assistant005