mmcv icon indicating copy to clipboard operation
mmcv copied to clipboard

Add annotation for ninja build in setup.py

Open imabackstabber opened this issue 2 years ago • 0 comments

Motivation

Add annotation, which explains why code (the part for adjusting number of cpu used in ninja build) will inevitably goes into Except block due to inherent design on MacOS,in setup.py.

Modification

Add annotation.

BC-breaking (Optional)

No

Use cases (Optional)

No

Checklist

Before PR:

  • [x] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [x] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [x] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [x] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [x] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [x] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • [x] CLA has been signed and all committers have signed the CLA in this PR.

imabackstabber avatar Mar 17 '22 01:03 imabackstabber