mmaction2 icon indicating copy to clipboard operation
mmaction2 copied to clipboard

[Fix] fix a bug in UT

Open hukkai opened this issue 3 years ago • 1 comments

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduces changes that break the back-compatibility of this repo? If so, please describe how it breaks the compatibility and how users should modify their codes to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

hukkai avatar Sep 19 '22 22:09 hukkai

Codecov Report

Base: 74.23% // Head: 74.24% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (0e8d933) compared to base (9f833de). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1937      +/-   ##
===========================================
+ Coverage    74.23%   74.24%   +0.01%     
===========================================
  Files          133      133              
  Lines         9327     9331       +4     
  Branches      1590     1590              
===========================================
+ Hits          6924     6928       +4     
  Misses        2080     2080              
  Partials       323      323              
Flag Coverage Δ
unittests 74.24% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/backbones/tanet.py 96.42% <100.00%> (+0.20%) :arrow_up:
mmaction/models/common/tam.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 20 '22 01:09 codecov[bot]

@ly015

hukkai avatar Sep 21 '22 04:09 hukkai