[Fix]: IndexError during mim download command execution in search.py

[CristoZhang]

Bug Fix: IndexError in mim command

We recently identified and fixed a bug that caused an IndexError: list index out of range exception when running the mim download command in Conda:

mim download mmsegmentation --config pspnet_r50-d8_4xb2-40k_cityscapes-512x1024 --dest .

The issue occurred in search.py at line 339, where a check for value[0] being an instance of dict was being made without first confirming whether value was empty. This resulted in the following error:

Traceback (most recent call):
  ...
  File "C:\Users\Enbla\anaconda3\envs\openmmlab\lib\site-packages\mim\commands\search.py", line 339, in _parse
    If isinstance(value[0], dict):
IndexError: list index out of range

The fix involves adding an additional check to ensure value is not empty before checking if value[0] is a dictionary instance:

elif isinstance(value, (list, tuple)):
    If value and isinstance(value[0], dict):

Following this fix, re-running the mim command successfully installs the model:

processing pspnet_r50-d8_4xb2-40k_cityscapes-512x1024...
Download ---------------------------------------- 187.1/187.1 MiB 2.5 MB/s eta 0:00:00
Successfully downloaded pspnet_r50-d8_512x1024_40k_cityscapes_20200605_003338-2966598c.pth to C:\Windows\System32
Successfully dumped pspnet_r50-d8_4xb2-40k_cityscapes-512x1024.py to C:\Windows\System32.

We recommend users encountering this issue to update to the latest version where this bug has been addressed.

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

1. Pre-commit or other linting tools are used to fix the potential lint issues.
2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
4. The documentation has been modified accordingly, like docstring or example tutorials.

[OpenMMLab-Assistant-004]

Hi @WikChang,

We'd like to express our appreciation for your valuable contributions to the mim. Your efforts have significantly aided in enhancing the project's quality. It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

[zhouzaida]

Hi, what is your mmsegmentation version?

[CristoZhang]

At the time of my pull request, the version of mmsegmentation was 1.1.0, I don't know if this problem has been fixed in 1.1.1.