OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Support Google Secret Manager

Open yu-iskw opened this issue 2 years ago • 11 comments

Is your feature request related to a problem? Please describe. We would like to store sensitive information in Google Secret Manager, as OpenMetadata already supports AWS Secrets Manager.

  • https://docs.open-metadata.org/deployment/secrets-manager
  • https://cloud.google.com/secret-manager/docs

Describe the solution you'd like We implement features for Google Secret Manager in OpenMetadata.

Describe alternatives you've considered N/A

Additional context N/A

yu-iskw avatar Jan 23 '23 23:01 yu-iskw

Thanks for pinging this. We don't have an expected ETA to add these new connections, as usually we push after it becomes valuable for multiple community members.

In case you'd like to contribute to this, we have some docs here https://docs.open-metadata.org/deployment/secrets-manager/how-to-add-a-new-implementation

Thanks

cc @nahuelverdugo

pmbrull avatar Jan 31 '23 09:01 pmbrull

@yu-iskw If you want to contribute to the implementation of Google Secret Manager let me know, and I will be happy to help!

nahuelverdugo avatar Feb 23 '23 14:02 nahuelverdugo

Could I be assigned to this issue? @nahuelverdugo some help in understanding the structure of how GSM should be implemented would be greately appreciated!

TeodorLungu avatar Mar 28 '23 17:03 TeodorLungu

Hi @TeodorLungu, I have assigned it to you. In the documentation, you have more information about how to add a new implementation of Secrets Manager.

nahuelverdugo avatar Mar 29 '23 06:03 nahuelverdugo

Hi @nahuelverdugo, is this still ongoing or I can take this task if no progression is made yet.

jayampathiadhikari avatar Jun 05 '23 19:06 jayampathiadhikari

@jayampathiadhikari If you are interested I can assign the task to you. Let me know

harshach avatar Jun 05 '23 19:06 harshach

@harshach yes please. Thank you

jayampathiadhikari avatar Jun 05 '23 19:06 jayampathiadhikari

Hi, can i work on this issue?

sameeraappana avatar Jan 25 '24 03:01 sameeraappana

hi @sameeraappana, assigned. Thanks!

pmbrull avatar Jan 29 '24 13:01 pmbrull

Hi. It looks like that the current assignee is too busy to tackle this issue. Can I try to implement this issue in parallel?

nakaken-churadata avatar Mar 17 '24 11:03 nakaken-churadata

I did to implements storing value to the GCP Secret Manager and getting value from it. It will take a few days to create PR. Wait a moment.

nakaken-churadata avatar Apr 07 '24 14:04 nakaken-churadata

Long time no see, I finished implementing and testing my code. So I'll try to create PR for this issue but I have some questions. Do I have to create documents? If so, Where is the source I have to modify? Thanks.

nakaken-churadata avatar May 27 '24 23:05 nakaken-churadata

hi @nakaken-churadata, documenting it here https://github.com/open-metadata/OpenMetadata/tree/main/openmetadata-docs/content/v1.4.x/deployment/secrets-manager/supported-implementations would be great, thanks!

pmbrull avatar May 28 '24 04:05 pmbrull

@nakaken-churadata any update on your PR. Thanks

harshach avatar Jun 22 '24 21:06 harshach

closed by https://github.com/open-metadata/OpenMetadata/pull/16505

pmbrull avatar Jul 02 '24 07:07 pmbrull