OpenMetadata Fixes #7105 -- Add support for dataType filter for TestDefinition request

Fixes #7105 -- Add support for dataType filter for TestDefinition request

Open TeddyCr opened this issue 2 years ago • 3 comments

Describe your changes :

Fixes #7105 -- Add support for dataType filter for TestDefinition request

Type of change :

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Sep 21 '22 15:09 TeddyCr

@TeddyCr Looks great!! however if the users are on 0.12.0 the migration script is not going to load the test definition new changes right?

Sep 21 '22 15:09 harshach

Wouldn't it recreate the test definition when they restart the server? I can try to do the upgrade and confirm.

Otherwise we might need to add an INSERT, wdyt? I know you want to move to Java to do any data manipulation.

Sep 21 '22 15:09 TeddyCr

Test summary

108 • 1 • 4 • 0

Run details


Project	openmetadata
Status	Failed
Commit	865bf1b4fc
Started	Sep 23, 2022 7:30 AM
Ended	Sep 23, 2022 7:48 AM
Duration	17:52 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 105

View run in Cypress Dashboard ➡️

Failures

	cypress/e2e/Pages/myData.spec.js		1
1	MyData page should work > My data, following & feed section should work properly for pipeline entity

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard