OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Generated Looker url is wrong in Lineage tab

Open larspettermadsstuen opened this issue 2 years ago • 1 comments

Affected module UI

Describe the bug The generated Looker URL (indicated in attached picture) seems wrong. The base part of the URL seems to be that of the OpenMetadata url (in my case, localhost), instead of the Looker instance host.

To Reproduce image

Expected behavior The base part of the url should point towards the Looker instance.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context Add any other context about the problem here.

larspettermadsstuen avatar Sep 21 '22 12:09 larspettermadsstuen

@nahuelverdugo might be related to the service connection

harshach avatar Sep 21 '22 15:09 harshach

@harshach from what I see in the JSON schema of Looker Connection, it seems that we are correctly exposing the hostPort of the configuration.

Can someone from @open-metadata/ui confirm how that URL is created? It should be serviceConnection.hostPort + dashboard.dashboardUrl.

nahuelverdugo avatar Sep 22 '22 07:09 nahuelverdugo

Hi @larspettermadsstuen, could you confirm if it is still happening in the latest version of OM?

nahuelverdugo avatar Nov 23 '22 14:11 nahuelverdugo

@pmbrull since you are looking at looker, can you confirm?

harshach avatar Dec 17 '22 03:12 harshach

The issue is still valid. The URL that is shown in the UI at the dashboard level points to the right looker instance, but from the lineage view instead of parsing <hostPort>/<dashboardUrl> it goes to localhost:8585/<dashboardUrl>.

Flagging this as a UI issue. Thanks

pmbrull avatar Dec 18 '22 10:12 pmbrull

hi, validated this with the latest release. If we check the example in the sandbox, URLs look good to me after we modified a couple of behaviors in the ingestion and UI. Thanks

example: https://sandbox.open-metadata.org/dashboard/sample_looker.orders/lineage

pmbrull avatar May 30 '23 16:05 pmbrull