OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fix #7172: List teams API throwing 404 for soft deleted team even with include=all

Open harshach opened this issue 2 years ago • 5 comments

Describe your changes :

I worked on the ..... because ...

Type of change :

  • [x] Bug fix

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [x] All new and existing tests passed.

Reviewers

harshach avatar Sep 21 '22 01:09 harshach

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Sep 21 '22 01:09 github-actions[bot]



Test summary

106 2 4 0


Run details

Project openmetadata
Status Failed
Commit d1042ffe1f
Started Sep 21, 2022 3:28 AM
Ended Sep 21, 2022 3:45 AM
Duration 17:24 💡
OS Linux Ubuntu - 20.04
Browser Chrome 105

View run in Cypress Dashboard ➡️


Failures

Pages/Customproperties.spec.js Failed
1 Custom Properties should work properly > Add Integer custom property for all Entities
AddNewService/glue.spec.js Failed
1 Glue Ingestion > add and ingest data

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 21 '22 01:09 cypress[bot]

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Sep 21 '22 03:09 github-actions[bot]

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 21 '22 03:09 sonarqubecloud[bot]

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.4% 84.4% Coverage
5.7% 5.7% Duplication

sonarqubecloud[bot] avatar Sep 21 '22 19:09 sonarqubecloud[bot]