OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fix #6917: startTs & endTs filters providing paginated data

Open harshach opened this issue 3 years ago • 11 comments

Describe your changes :

I worked on the ..... because ... Closes #6917

Type of change :

  • [x] Improvement

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [x] All new and existing tests passed.

Reviewers

harshach avatar Sep 20 '22 23:09 harshach



Test summary

105 3 4 0


Run details

Project openmetadata
Status Failed
Commit eb3e08fa22
Started Sep 21, 2022 4:10 AM
Ended Sep 21, 2022 4:27 AM
Duration 17:02 💡
OS Linux Ubuntu - 20.04
Browser Chrome 105

View run in Cypress Dashboard ➡️


Failures

myData.spec.js Failed
1 MyData page should work > My data, following & feed section should work properly for pipeline entity
Bots.spec.js Failed
1 Bots Page should work properly > Update display name and description
2 Bots Page should work properly > Delete created bot

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 20 '22 23:09 cypress[bot]

@TeddyCr not sure if you are using these apis for python, can you take a look

harshach avatar Sep 21 '22 00:09 harshach

Added UI side of changes, It's working fine with updated API support! Thanks @harshach

ShaileshParmar11 avatar Sep 21 '22 03:09 ShaileshParmar11

@TeddyCr not sure if you are using these apis for python, can you take a look

Looking at it. The end to end test for the test suite seems to be throwing a 500

TeddyCr avatar Sep 21 '22 05:09 TeddyCr

@harshach this endpoint /testCase/{testCaseFqn}/testCaseResultis throwing a 500. You can check it if you spin up the server and run the below command

curl --location --request GET 'http://localhost:8585/api/v1/testCase/sample_data.ecommerce_db.shopify.dim_address.last_name.column_values_to_match_regex/testCaseResult'

Screenshot 2022-09-21 at 7 32 58 AM

TeddyCr avatar Sep 21 '22 05:09 TeddyCr

@TeddyCr startTs and endTs is a required field now. If you are not passing we will run into an error. I am adding validations to throw a better error

harshach avatar Sep 21 '22 05:09 harshach

@TeddyCr startTs and endTs is a required field now. If you are not passing we will run into an error. I am adding validations to throw a better error

@harshach could we also mark it as required in swagger? Screenshot 2022-09-21 at 7 59 13 AM

TeddyCr avatar Sep 21 '22 05:09 TeddyCr

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 21 '22 06:09 sonarqubecloud[bot]

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Sep 21 '22 18:09 github-actions[bot]

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 21 '22 18:09 sonarqubecloud[bot]

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

88.5% 88.5% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 21 '22 19:09 sonarqubecloud[bot]