OpenMetadata
OpenMetadata copied to clipboard
Fix #6917: startTs & endTs filters providing paginated data
Describe your changes :
I worked on the ..... because ... Closes #6917
Type of change :
- [x] Improvement
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
- [x] I have read the CONTRIBUTING document.
- [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [x] All new and existing tests passed.
Reviewers
Test summary
Run details
| Project | openmetadata |
| Status | Failed |
| Commit | eb3e08fa22 |
| Started | Sep 21, 2022 4:10 AM |
| Ended | Sep 21, 2022 4:27 AM |
| Duration | 17:02 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Chrome 105 |
View run in Cypress Dashboard ➡️
Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
@TeddyCr not sure if you are using these apis for python, can you take a look
Added UI side of changes, It's working fine with updated API support! Thanks @harshach
@TeddyCr not sure if you are using these apis for python, can you take a look
Looking at it. The end to end test for the test suite seems to be throwing a 500
@harshach this endpoint /testCase/{testCaseFqn}/testCaseResultis throwing a 500. You can check it if you spin up the server and run the below command
curl --location --request GET 'http://localhost:8585/api/v1/testCase/sample_data.ecommerce_db.shopify.dim_address.last_name.column_values_to_match_regex/testCaseResult'

@TeddyCr startTs and endTs is a required field now. If you are not passing we will run into an error. I am adding validations to throw a better error
@TeddyCr startTs and endTs is a required field now. If you are not passing we will run into an error. I am adding validations to throw a better error
@harshach could we also mark it as required in swagger?

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
The Java checkstyle failed.
Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.
You can install the pre-commit hooks with make install_test precommit_install.
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! 
[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed! 

