OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Published 20 hours ago • verified publisher icon open-metadata

Fix #7524 Backend: Allow users to rename the Glossary Term

Open vivekratnavel opened this issue 2 years ago • 5 comments

Describe your changes :

Allow patching "name" field of Glossary Term

Type of change :

  • [x] Improvement

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] I have commented on my code, particularly in hard-to-understand areas.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [x] All new and existing tests passed.

Reviewers

vivekratnavel avatar Sep 17 '22 00:09 vivekratnavel


Test summary

86 • 1 • 4 • 0

Run details
Project openmetadata
Status Failed
Commit 80d334c50f
Started Sep 19, 2022 6:16 AM
Ended Sep 19, 2022 6:35 AM
Duration 18:51 💡
OS Linux Ubuntu - 20.04
Browser Chrome 105

View run in Cypress Dashboard ➡️

Failures

cypress/e2e/AddNewService/glue.spec.js 1 Failed
1 Glue Ingestion > add and ingest data

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 17 '22 00:09 cypress[bot]

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 19 '22 06:09 sonarqubecloud[bot]

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.0% 97.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 19 '22 06:09 sonarqubecloud[bot]

@vivekratnavel and @harshach, I was under the impression that we will only change the display name for the glossary name change. Is that not the case?

sureshms avatar Sep 21 '22 15:09 sureshms

@sureshms if we do not change the name of the glossary term, it will be weird in sharing the links to the glossary term and as well as FQN of the term. There will be unwanted issues on how we are looking up in elastic search like based on fqn vs display name. My concern was , lets say there is Business Glossary.Sales.Order -> Business Glossary.Product.order there is big difference in identifying the term if we only change the display name. We are not shipping this in 0.12.1, so we have time to discuss

harshach avatar Sep 21 '22 16:09 harshach