OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fix Ingestion Time Partitioned Tables on Profiler

Open ayush-shah opened this issue 3 years ago • 5 comments

Describe your changes :

fix #5458

Type of change :

  • [x] Bug fix
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [x] All new and existing tests passed.

Reviewers

@open-metadata/ingestion

ayush-shah avatar Sep 15 '22 19:09 ayush-shah

@ayush-shah it seems this was not tested locally as it is failing when trying to profile local_bigquery.modified-leaf-330420.sdoh_cms_dual_eligible_enrollment.ingestion_partition_table. Let me know if you need help with anything there.

TeddyCr avatar Sep 16 '22 12:09 TeddyCr



Test summary

75 34 3 0


Run details

Project openmetadata
Status Failed
Commit 14a3deca7c
Started Sep 26, 2022 8:56 AM
Ended Sep 26, 2022 9:19 AM
Duration 23:11 💡
OS Linux Ubuntu - 20.04
Browser Chrome 105

View run in Cypress Dashboard ➡️


Failures

myData.spec.js Failed
1 MyData page should work > My data, following & feed section should work properly for table entity
2 MyData page should work > My data, following & feed section should work properly for topic entity
3 MyData page should work > My data, following & feed section should work properly for dashboard entity
4 MyData page should work > My data, following & feed section should work properly for pipeline entity
DataQualityAndProfiler.js Failed
1 Data Quality and Profiler should work properly > Add and ingest mysql data
2 Data Quality and Profiler should work properly > Add Profiler ingestion
3 Data Quality and Profiler should work properly > Add table test case with new test suite
4 Data Quality and Profiler should work properly > Edit Test Case should work properly
5 Data Quality and Profiler should work properly > Delete Test Case should work properly
6 Data Quality and Profiler should work properly > Add Column test case should work properly
This comment includes only the first 10 test failures. See all 34 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 19 '22 04:09 cypress[bot]

Adding tests for the paritioned tables profiling workflow

ayush-shah avatar Sep 19 '22 10:09 ayush-shah

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Sep 21 '22 05:09 github-actions[bot]

[open-metadata-ingestion] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

17.9% 17.9% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 21 '22 06:09 sonarqubecloud[bot]

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Sep 22 '22 08:09 github-actions[bot]

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Sep 22 '22 10:09 github-actions[bot]

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Sep 22 '22 10:09 github-actions[bot]