OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Antlr Grammar implemented, Imports fixed

Open ayush-shah opened this issue 3 years ago • 1 comments
trafficstars

Describe your changes :

fixes #6589

Type of change :

  • [x] Improvement
  • [x] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [x] All new and existing tests passed.

Reviewers

@open-metadata/backend @open-metadata/ingestion @open-metadata/ui

ayush-shah avatar Aug 09 '22 14:08 ayush-shah

@ayush-shah can we implement the Python side of things as well? That will be needed for the test suite

pmbrull avatar Aug 16 '22 07:08 pmbrull

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Aug 16 '22 13:08 github-actions[bot]

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Aug 16 '22 14:08 github-actions[bot]

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Aug 16 '22 14:08 github-actions[bot]

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 18 '22 12:08 sonarqubecloud[bot]

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 18 '22 12:08 sonarqubecloud[bot]

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 18 '22 12:08 sonarqubecloud[bot]

Merging as the tests failing are not related to this pr

ayush-shah avatar Aug 18 '22 13:08 ayush-shah