OpenMetadata dagster-connector-added

dagster-connector-added

Open codingwithabhi opened this issue 1 year ago • 8 comments

Describe your changes :

I worked on the adding Dagster Connector. fix #1801

Type of change :

[x] New feature

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ]

Reviewers

@open-metadata/ingestion

Aug 02 '22 12:08 codingwithabhi

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

Aug 02 '22 12:08 github-actions[bot]

Test summary

63 • 0 • 4 • 0

Run details


Project	openmetadata
Status	Passed
Commit	b44a441621
Started	Aug 13, 2022 8:16 AM
Ended	Aug 13, 2022 8:28 AM
Duration	12:17 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Aug 02 '22 13:08 cypress[bot]

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Aug 02 '22 18:08 github-actions[bot]

@codingwithabhi can we add the docs for dasgter as well in this pr?

Aug 03 '22 13:08 ulixius9

Thanks, this looks good. Let's add tests and docs, and once the tests pass, we can merge this in! Thanks

Aug 04 '22 13:08 pmbrull

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Aug 04 '22 18:08 github-actions[bot]

@codingwithabhi can you rebase with main and check if the tests passes