OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

[Backend][SAML] SAML Support

Open mohityadav766 opened this issue 2 years ago • 8 comments

Describe your changes :

Saml support #2664

Type of change :

  • [x] Improvement
  • [x] New feature

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [x] All new and existing tests passed.

Reviewers

mohityadav766 avatar Jul 05 '22 12:07 mohityadav766

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

github-actions[bot] avatar Jul 05 '22 12:07 github-actions[bot]

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Jul 14 '22 05:07 github-actions[bot]

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Aug 08 '22 07:08 github-actions[bot]

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Aug 09 '22 06:08 github-actions[bot]

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 13 '22 07:09 sonarqubecloud[bot]

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

29.2% 29.2% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 13 '22 07:09 sonarqubecloud[bot]

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

11.3% 11.3% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 13 '22 07:09 sonarqubecloud[bot]

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 21 '22 12:09 sonarqubecloud[bot]

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

29.2% 29.2% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 21 '22 12:09 sonarqubecloud[bot]

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

9.7% 9.7% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 21 '22 12:09 sonarqubecloud[bot]

@mohityadav766 guessing this is not needed. Closing.

harshach avatar Nov 17 '22 03:11 harshach

@harshach why is not needed ??

dpadmor avatar Nov 17 '22 10:11 dpadmor