OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Broken data quality tests possible could be posted to OM

Open Curiosady opened this issue 3 years ago • 1 comments

Affected module Ingestion Framework

Describe the bug For now it is possible to publish data quality tests with broken config. After that happens all profiler jobs fails because python OpenMetadata REST client on ingestion side lists all tables and validates data quality configs. Thus just one broken config breaks all profilers and tests.

To Reproduce Register table or column test with broken config. Something like this tableTests': [{'id': '', 'name': 'table.tableRowCountToEqual', 'description': 'Test description', 'testCase': {'config': 1, 'tableTestType': 'tableRowCountToEqual'}. Check that not only this test fails, but all other tests and profilers fails as well.

Expected behavior It should be not possible to post fundamentally broken tests to OM. Need to perform some form of validation before posting. This should prevent massive profiler workflows failure.

Version:

  • Linux
  • Python version: 3.9
  • OpenMetadata version: 0.10.1
  • OpenMetadata Ingestion package version: openmetadata-ingestion[hive]==0.10.1

Curiosady avatar Jun 06 '22 09:06 Curiosady

should be covered by https://github.com/open-metadata/OpenMetadata/pull/6416

Let's validate it

pmbrull avatar Aug 04 '22 08:08 pmbrull