OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Feat(ui) : Enhance UI input method for multiple filter conditions when configuring ingestion pipelines

Open shrushti2000 opened this issue 6 months ago • 3 comments

Fixes #15353 and #20622

Filter Input Enhancement: Multi-value Support

Problem

The filter input component had limited functionality for handling multiple values, making it difficult for users to efficiently input multiple filter conditions.

Solution

Enhanced the filter input component to support efficient multi-value input with proper handling of special characters and duplicates.

Key Improvements

  1. Multi-value Input Support

    • Users can now paste comma-separated values directly into the filter input
    • Values are automatically split and added as individual filter conditions
    • Support for both direct input and copy-paste operations
  2. Special Character Handling

    • If the value has commas in between them , the values should be wrapped with double quotes.
    • If the value has double quotes in them, it should be escaped with escape character like \
  3. Duplicate Prevention

    • The input does not allow entering duplicate filters.
    • Implemented automatic duplicate detection and removal
    • Ensures each filter condition appears only once

https://github.com/user-attachments/assets/0de0657d-53cd-4f4f-94a0-decd03d88e8c

Type of change:

  • [ ] Bug fix
  • [ ] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

shrushti2000 avatar May 26 '25 10:05 shrushti2000

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.65% (45897/72110) 39.04% (18726/47970) 43% (5451/12678)

github-actions[bot] avatar May 26 '25 11:05 github-actions[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Jun 16 '25 09:06 github-actions[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Jun 16 '25 16:06 github-actions[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Jun 17 '25 07:06 github-actions[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Jun 17 '25 11:06 github-actions[bot]