OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fix #18110: Allow serving UI under a subpath

Open harshach opened this issue 1 year ago • 5 comments

Describe your changes:

Fixes #18110

I worked on ... because ...

Type of change:

  • [ ] Bug fix
  • [ ] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

harshach avatar Oct 04 '24 02:10 harshach

@harshach I have added some changes to fix path issue from UI side and also serve modified Index.html using OpenMetadataAssetServlet with help of @mohityadav766 can you review backend changes once?

chirag-madlani avatar Oct 07 '24 16:10 chirag-madlani

@harshach I have added some changes to fix path issue from UI side and also serve modified Index.html using OpenMetadataAssetServlet with help of @mohityadav766 can you review backend changes once?

They need improvement @chirag-madlani , they were just to unblock you we need to refactor those a bit

mohityadav766 avatar Oct 07 '24 16:10 mohityadav766

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.47% (44813/70609) 38.42% (17935/46683) 42.99% (5332/12402)

github-actions[bot] avatar Oct 07 '24 16:10 github-actions[bot]

Folks, do you need any help on this? I really need this PR, so I'm willing to help. Can somebody please guide me? Thank you!

loringit avatar Jan 24 '25 08:01 loringit

hi guys, i followed this issue and found some error that if use deployed version it doesn't work properly, I mean half of UI uses basePath env-variable, see below image image (1)

buddzbuddy avatar Jul 01 '25 05:07 buddzbuddy

@buddzbuddy thanks for pointing the issue, do you want to fix and open a PR?

harshach avatar Jul 01 '25 05:07 harshach

@harshach yes sure I'd love it!

buddzbuddy avatar Jul 01 '25 05:07 buddzbuddy