OpenMetadata
OpenMetadata copied to clipboard
Fix #18110: Allow serving UI under a subpath
Describe your changes:
Fixes #18110
I worked on ... because ...
Type of change:
- [ ] Bug fix
- [ ] Improvement
- [ ] New feature
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation
Checklist:
- [x] I have read the CONTRIBUTING document.
- [ ] My PR title is
Fixes <issue-number>: <short explanation> - [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
@harshach I have added some changes to fix path issue from UI side and also serve modified Index.html using OpenMetadataAssetServlet with help of @mohityadav766 can you review backend changes once?
@harshach I have added some changes to fix path issue from UI side and also serve modified Index.html using OpenMetadataAssetServlet with help of @mohityadav766 can you review backend changes once?
They need improvement @chirag-madlani , they were just to unblock you we need to refactor those a bit
Jest test Coverage
UI tests summary
| Lines | Statements | Branches | Functions |
|---|---|---|---|
| 63.47% (44813/70609) | 38.42% (17935/46683) | 42.99% (5332/12402) |
Quality Gate passed for 'open-metadata-ui'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Quality Gate passed for 'open-metadata-ingestion'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Folks, do you need any help on this? I really need this PR, so I'm willing to help. Can somebody please guide me? Thank you!
Quality Gate passed for 'open-metadata-ui'
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
hi guys, i followed this issue and found some error that if use deployed version it doesn't work properly, I mean half of UI uses basePath env-variable, see below
@buddzbuddy thanks for pointing the issue, do you want to fix and open a PR?
@harshach yes sure I'd love it!