OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fix # 16475 : Support dashboards field in chart entity

Open sonika-shah opened this issue 1 year ago • 5 comments

Describe your changes:

Fixes #16475 #16390

  • Support dashboards field in chart entity

UI :

  • support chart in suggestion box with redirect to dashboard page
  • support charts in glossary asset with relevant data in right side panel
  • supported playwright test for charts add as glossary assets

Will require indexing once to see the correct changes

https://github.com/open-metadata/OpenMetadata/assets/66266464/57608830-bcd0-4952-b09e-469bebeffd6d

https://github.com/open-metadata/OpenMetadata/assets/66266464/0cdeadd9-4619-4fe9-a362-59a007b0bb1a

Type of change:

  • [x] Bug fix
  • [x] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

sonika-shah avatar Jun 13 '24 07:06 sonika-shah

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Jun 13 '24 07:06 github-actions[bot]

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.3% (35471/54319) 42.06% (14055/33417) 43.99% (4344/9876)

github-actions[bot] avatar Jun 18 '24 13:06 github-actions[bot]

Passing run #34424 ↗︎

0 78 262 0 Flakiness 0

Details:

minor fix
Project: openmetadata Commit: 162ce69907
Status: Passed Duration: 09:47 💡
Started: Jun 18, 2024 1:32 PM Ended: Jun 18, 2024 1:42 PM

Review all test suite changes for PR #16646 ↗︎

cypress[bot] avatar Jun 18 '24 13:06 cypress[bot]

@Sachin-chaurasiya changes made as per comments !

Ashish8689 avatar Jul 01 '24 07:07 Ashish8689