OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fixes 16582: support SASL_SSL kafka auth for OpenLineage pipeline connector

Open MChamberlin opened this issue 1 year ago • 6 comments

Describe your changes:

Fixes 16582.

Update OpenLineage pipeline connector config to support SASL_SSL kafka client connections, for use with e.g. Confluent Cloud kafka clusters.

Screenshot 2024-06-10 at 4 06 09 PM

Type of change:

  • [x] Improvement

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My PR title is Fixes <issue-number>: <short explanation>
  • [x] I have commented on my code, particularly in hard-to-understand areas.
  • [x] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • [x] For connector/ingestion changes: I updated the documentation.

MChamberlin avatar Jun 10 '24 20:06 MChamberlin

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Jun 10 '24 20:06 github-actions[bot]

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.18% (35156/53940) 41.97% (13897/33109) 43.95% (4317/9823)

github-actions[bot] avatar Jun 11 '24 11:06 github-actions[bot]

awesome, thanks @MChamberlin - do you think this could be added on top of https://github.com/open-metadata/OpenMetadata/pull/16608 (once it's merged)?

mgorsk1 avatar Jun 11 '24 13:06 mgorsk1

@MChamberlin thanks for the PR. Can you please check the comments above. Once addressed we can merge it in.

harshach avatar Jun 22 '24 20:06 harshach

@harshach Is this ok to merge now? I've addressed the comments and the failing tests look unrelated.

MChamberlin avatar Jul 03 '24 13:07 MChamberlin