OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Empty quick filters

Open karanh37 opened this issue 1 year ago • 6 comments

Describe your changes:

  1. Add Empty Quick Filters in Explore
  2. Minor fixes related to search encoding. Fixes #16001

https://github.com/open-metadata/OpenMetadata/assets/33024356/c3384944-671f-4e0e-ae7c-3ea2c3921f71

I worked on ... because ...

Type of change:

  • [ ] Bug fix
  • [ ] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

karanh37 avatar May 23 '24 14:05 karanh37

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.83% (34849/53757) 41.73% (13758/32971) 43.66% (4276/9794)

github-actions[bot] avatar May 23 '24 14:05 github-actions[bot]

Passing run #34269 ↗︎

0 379 8 0 Flakiness 0

Details:

fix tests
Project: openmetadata Commit: a615bef551
Status: Passed Duration: 34:51 💡
Started: May 27, 2024 9:22 AM Ended: May 27, 2024 9:57 AM

Review all test suite changes for PR #16402 ↗︎

cypress[bot] avatar May 24 '24 07:05 cypress[bot]

@karanh37 what test coverage we have for this

harshach avatar May 24 '24 14:05 harshach

@harshach - we have added two tests. First test - We are individually checking each Null options and verifying if the API request is correct. Second test - We are checking for Multiple Owners. We select No Owner and Aaron Johnson and verify multiple owner scenario is working fine.

karanh37 avatar May 24 '24 14:05 karanh37

we need to add tests for each of those fields where we expecting None to work. Having only one field test is not good enough

harshach avatar May 24 '24 15:05 harshach

@harshach - added tests for all Owner Tag Tier and Domain Both single select and multi select cases added for all of above.

karanh37 avatar May 25 '24 16:05 karanh37