Empty quick filters
Describe your changes:
- Add Empty Quick Filters in Explore
- Minor fixes related to search encoding. Fixes #16001
https://github.com/open-metadata/OpenMetadata/assets/33024356/c3384944-671f-4e0e-ae7c-3ea2c3921f71
I worked on ... because ...
Type of change:
- [ ] Bug fix
- [ ] Improvement
- [ ] New feature
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation
Checklist:
- [x] I have read the CONTRIBUTING document.
- [ ] My PR title is
Fixes <issue-number>: <short explanation> - [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
Jest test Coverage
UI tests summary
| Lines | Statements | Branches | Functions |
|---|---|---|---|
| 64.83% (34849/53757) | 41.73% (13758/32971) | 43.66% (4276/9794) |
Passing run #34269 ↗︎
Details:
| fix tests | |||
| Project: openmetadata | Commit: a615bef551 |
||
| Status: Passed | Duration: 34:51 💡 | ||
| Started: May 27, 2024 9:22 AM | Ended: May 27, 2024 9:57 AM | ||
Review all test suite changes for PR #16402 ↗︎
@karanh37 what test coverage we have for this
@harshach - we have added two tests.
First test - We are individually checking each Null options and verifying if the API request is correct.
Second test - We are checking for Multiple Owners. We select No Owner and Aaron Johnson and verify multiple owner scenario is working fine.
we need to add tests for each of those fields where we expecting None to work. Having only one field test is not good enough
@harshach - added tests for all Owner Tag Tier and Domain
Both single select and multi select cases added for all of above.
Quality Gate passed for 'open-metadata-ui'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code