OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Activity feed bugs and improvements

Open aniketkatkar97 opened this issue 1 year ago • 4 comments

Affected module UI

Describe the bug

  • [ ] Activity tab reloads when commented in the thread resetting the selected thread. Prevent the reload and only update the selected thread

https://github.com/open-metadata/OpenMetadata/assets/51777795/64b29095-8a3a-46dc-a62c-6bee7bad1238

  • [ ] persona update feed

https://github.com/open-metadata/OpenMetadata/assets/71748675/678ae12b-c5a6-4ed3-855c-81f13fde8760

  • [ ] plus minus icons should be center aligned. image

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context Add any other context about the problem here.

aniketkatkar97 avatar May 20 '24 05:05 aniketkatkar97

  • [x] Incident Manager shows empty but the breadcrumb shows incident manager Image 1) I see Incident Manager for successful test case Image 2) On clicking Incident Manager on the breadcrumbs from Image 1, i get to see empty incident manager Image 3) I got to Image 1 page from Activity feed shown in this image
Screenshot 2024-05-23 at 3 51 47 PM Screenshot 2024-05-23 at 3 52 05 PM

image

ayush-shah avatar May 23 '24 10:05 ayush-shah

  • [x] dashboard display needs to be shown image

  • [ ] it looks like activity feed is repeating for a failed test case result? the asset link at the top taking it image

  • [x] align + icon with description image

harshach avatar May 24 '24 02:05 harshach

  • [x] Long description overflow image

aniketkatkar97 avatar May 24 '24 16:05 aniketkatkar97

  • [ ] Parse Test Case changes to show case what exactly is updated instead of json payload image

  • [x] span classes in description need to be rendered image

  • [x] what are we rendering in test case results, only failed test graph should be shown if the tests are passing we will show the metrics cc @mohityadav766 image

  • [x] Activity Feed should be infinitely scrollable on the landing page instead of redirecting user to their profile page cc @aniketkatkar97 @chirag-madlani

  • [ ] ~~When Style applied to a term or tag, it should be updated in activity feed instead of showing style json~~ - (We are not showing the change feed for this)

harshach avatar May 24 '24 17:05 harshach

Activity Feed does not display the knowledge center article's title

https://github.com/open-metadata/OpenMetadata/assets/28966081/93bcb44f-6ba0-4de7-81f2-918ede2c147d

OnkarVO7 avatar May 28 '24 08:05 OnkarVO7

  • [ ] Old feed component in the conversation panel on entity page and alignment issue
Screenshot 2024-05-28 at 12 29 54 PM Screenshot 2024-05-28 at 12 30 42 PM

aniketkatkar97 avatar May 28 '24 08:05 aniketkatkar97

  • [ ] distinguish glossary terms and tags from each other on activity feed image image image

ayush-shah avatar May 28 '24 13:05 ayush-shah

@mohityadav766 Needed BE support for this.

  • [x] There are some entities with the display name along with it. And we don't have entity info in the Feed. Having the entity reference for the particular entity will help us to display the updated name for the feed. image (7) image (8)

  • [ ] For any kind of column update in the entity we don't have info about the column in the Feed data. It's hard to state the changes belong to table or column. image image

Feed not Generating for this change event : (We only show if someone ask for it!)

  • [ ] Classification re-naming and description change.
  • [ ] Tag displayName, description, re-naming, style change.
  • [ ] Removing Domain in Glossary
  • [ ] Glossary updating description and re-naming displayName
  • [ ] Glossary Term re-naming / displayName
  • [ ] Team update email, domain, owner, subscription,displayName and description

Feed generation not needed :

  • [ ] I have updated the widgets in the Persona and it created a feed as entityCreated, I don't think we should we should created any feed for this.

Need Feed info with cardSyle : ( we are not going to show the feed for this @mohityadav766 )

  • [ ] image
  • [ ] image
  • [ ] image
  • [ ] image
  • [ ] image
  • [ ] image

@Rupchavan Need mock for the above feeds!

Ashish8689 avatar May 30 '24 07:05 Ashish8689

Feed cardStyle for tags update in entities will come like:

  • Tags : Only for Tags update
  • GlossaryTags: Only for Glossary update
  • TagsAndGlossary: Or both the Tags and Glossary update

cc: @mohityadav766

Ashish8689 avatar May 30 '24 08:05 Ashish8689

  • [x] Activity feed going from one thread to another with the same profile image sticks on another user

https://github.com/open-metadata/OpenMetadata/assets/66266464/3181e8c6-0b2c-4b97-9ef5-97662e6d020d

Ashish8689 avatar Jun 04 '24 06:06 Ashish8689

  • [x] Breadcrumb for the test case should be Data quality / Test Case

image (6)

ShaileshParmar11 avatar Jun 07 '24 09:06 ShaileshParmar11

  • [x] Changing the language to other than English, text {{entity}} is added in feed header. Screenshot 2024-07-05 at 1 39 31 PM

aniketkatkar97 avatar Jul 05 '24 08:07 aniketkatkar97

Reopening this as still some cases pending

Ashish8689 avatar Jul 15 '24 10:07 Ashish8689

Feed cardStyle for tags update in entities will come like:

  • Tags : Only for Tags update
  • GlossaryTags: Only for Glossary update
  • TagsAndGlossary: Or both the Tags and Glossary update

cc: @mohityadav766

@Ashish8689 this information is already there

mohityadav766 avatar Jul 19 '24 06:07 mohityadav766