OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

feat: use native trino client authentication classes

Open mgorsk1 opened this issue 1 year ago • 8 comments

Describe your changes:

Fixes

Since Trino client used in trino integration provides classes for different types of authentication (and includes both basic and jwt) classes I worked on refactoring trino/connection.py class to use them directly instead of workarounds with adjusting the connection url because it enables us to streamline inclusion of different authentication mechanisms and also enables us to use Oauth2Authentication class in a same way, which can be handy for some use cases. It will also make it super easy to extend in the future with other supported authentication mechanisms such as certificate or kerberos authentication.

Type of change:

  • [ ] Bug fix
  • [x] Improvement
  • [x] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

mgorsk1 avatar May 09 '24 12:05 mgorsk1

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar May 09 '24 12:05 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar May 09 '24 12:05 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar May 09 '24 12:05 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar May 09 '24 18:05 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar May 10 '24 06:05 github-actions[bot]

@ulixius9 whats the status of this PR?

harshach avatar Nov 09 '24 19:11 harshach