OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fix #16046 : modify glossaryTerms api endpoint to support querying immediate children with childrenCount

Open sonika-shah opened this issue 1 year ago • 2 comments

Describe your changes:

Fixes #16046

Worked on enhancement to the existing /api/v1/glossaryTerms endpoint. It adds support for querying immediate children of a specified parent glossary term fqn.

Changes made -

  • added field childrenCount in existing glossaryTerm.json , we are not storing childrenCount in db, it is created on fly.

  • Added a new query parameter directChildrenOf to specify the parent glossary term fqn.

  • Updated the response schema to include the childrenCount field for each immediate child glossary term.

  • API : api/v1/glossaryTerms?directChildrenOf=<parentFQN>&fields=childrenCount

Type of change:

  • [ ] Bug fix
  • [x] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My PR title is Fixes <issue-number>: <short explanation>
  • [x] I have commented on my code, particularly in hard-to-understand areas.
  • [x] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • [x] I have added tests around the new logic.
  • [ ] For connector/ingestion changes: I updated the documentation.

sonika-shah avatar Apr 26 '24 09:04 sonika-shah

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Apr 26 '24 09:04 github-actions[bot]

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 29 '24 14:04 sonarqubecloud[bot]