OpenMetadata
OpenMetadata copied to clipboard
revamp announcement card
Describe your changes:
- I worked on revamping the announcement card - https://www.figma.com/proto/KMwnWm5vnfPNZiru4z3lbi/OpenMetadata-Final-Screens?page-id=1729%3A95696&type=design&node-id=2377-195572&viewport=4342%2C12873%2C0.49&t=bOFArrzf206J0jyp-1&scaling=min-zoom&starting-point-node-id=4377%3A89873
- Separate out the announcement code from the activity feed
- Refactor ProfilePicture Component as per latest mock design https://www.figma.com/file/KMwnWm5vnfPNZiru4z3lbi/OpenMetadata-Final-Screens?type=design&node-id=2296-178440&mode=design
Type of change:
- [ ] Bug fix
- [x] Improvement
- [ ] New feature
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation
Checklist:
- [x] I have read the CONTRIBUTING document.
- [ ] My PR title is
Fixes <issue-number>: <short explanation> - [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
17 failed tests on run #34023 ↗︎
Details:
| skip cypress failure due to flakiness | |||
| Project: openmetadata | Commit: 8475fb7d97 |
||
| Status: Failed | Duration: 51:13 💡 | ||
| Started: Apr 30, 2024 7:07 AM | Ended: Apr 30, 2024 7:58 AM | ||
Pages/Entity.spec.ts • 7 failed tests • cypress-ci-mysql-pr-8890500697-1
Pages/Database.spec.ts • 6 failed tests • cypress-ci-mysql-pr-8890500697-1
Features/QueryEntity.spec.ts • 2 failed tests • cypress-ci-mysql-pr-8890500697-1
| Test | Artifacts | |
|---|---|---|
| Query Entity > Update owner, description and tag |
Screenshots
Video
|
|
| Query Entity > Verify query filter |
Screenshots
Video
|
|
Pages/MyData.spec.ts • 2 failed tests • cypress-ci-mysql-pr-8890500697-1
| Test | Artifacts | |
|---|---|---|
| My Data page > Verify user as owner feed widget |
Screenshots
Video
|
|
| My Data page > Verify team as owner feed widget |
Screenshots
Video
|
|
Review all test suite changes for PR #16016 ↗︎
The Python checkstyle failed.
Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.
You can install the pre-commit hooks with make install_test precommit_install.
The Python checkstyle failed.
Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.
You can install the pre-commit hooks with make install_test precommit_install.
Jest test Coverage
UI tests summary
| Lines | Statements | Branches | Functions |
|---|---|---|---|
| 64.87% (34346/52948) | 42.04% (13551/32235) | 43.57% (4228/9704) |
The Python checkstyle failed.
Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.
You can install the pre-commit hooks with make install_test precommit_install.
The Python checkstyle failed.
Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.
You can install the pre-commit hooks with make install_test precommit_install.
@chirag-madlani @karanh37 changes made as per commets!
Quality Gate passed for 'open-metadata-ui'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
6.6% Duplication on New Code