OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

revamp announcement card

Open Ashish8689 opened this issue 1 year ago • 8 comments

Describe your changes:

  • I worked on revamping the announcement card - https://www.figma.com/proto/KMwnWm5vnfPNZiru4z3lbi/OpenMetadata-Final-Screens?page-id=1729%3A95696&type=design&node-id=2377-195572&viewport=4342%2C12873%2C0.49&t=bOFArrzf206J0jyp-1&scaling=min-zoom&starting-point-node-id=4377%3A89873
  • Separate out the announcement code from the activity feed
  • Refactor ProfilePicture Component as per latest mock design https://www.figma.com/file/KMwnWm5vnfPNZiru4z3lbi/OpenMetadata-Final-Screens?type=design&node-id=2296-178440&mode=design
image image image image

Type of change:

  • [ ] Bug fix
  • [x] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Ashish8689 avatar Apr 24 '24 11:04 Ashish8689

17 failed tests on run #34023 ↗︎

17 307 6 0 Flakiness 0

Details:

skip cypress failure due to flakiness
Project: openmetadata Commit: 8475fb7d97
Status: Failed Duration: 51:13 💡
Started: Apr 30, 2024 7:07 AM Ended: Apr 30, 2024 7:58 AM
Failed  Pages/Entity.spec.ts • 7 failed tests • cypress-ci-mysql-pr-8890500697-1

View Output Video

Test Artifacts
Entity detail page > Dashboard page > GlossaryTerm assign, update & delete Screenshots Video
Entity detail page > Dashboard page > Soft delete Screenshots Video
Entity detail page > Pipeline page > Tags assign, update & delete Screenshots Video
Entity detail page > Pipeline page > GlossaryTerm assign, update & delete Screenshots Video
Entity detail page > Pipeline page > Soft delete Screenshots Video
Entity detail page > Container page > Tags assign, update & delete Screenshots Video
Entity detail page > Container page > Soft delete Screenshots Video
Failed  Pages/Database.spec.ts • 6 failed tests • cypress-ci-mysql-pr-8890500697-1

View Output Video

Test Artifacts
Database hierarchy details page > Database page > Tags assign, update & delete Screenshots Video
Database hierarchy details page > Database page > Soft delete Screenshots Video
Database hierarchy details page > Database Schema page > Tags assign, update & delete Screenshots Video
Database hierarchy details page > Database Schema page > Soft delete Screenshots Video
Database hierarchy details page > Store Procedure page > GlossaryTerm assign, update & delete Screenshots Video
Database hierarchy details page > Store Procedure page > Soft delete Screenshots Video
Failed  Features/QueryEntity.spec.ts • 2 failed tests • cypress-ci-mysql-pr-8890500697-1

View Output Video

Test Artifacts
Query Entity > Update owner, description and tag Screenshots Video
Query Entity > Verify query filter Screenshots Video
Failed  Pages/MyData.spec.ts • 2 failed tests • cypress-ci-mysql-pr-8890500697-1

View Output Video

Test Artifacts
My Data page > Verify user as owner feed widget Screenshots Video
My Data page > Verify team as owner feed widget Screenshots Video

Review all test suite changes for PR #16016 ↗︎

cypress[bot] avatar Apr 24 '24 12:04 cypress[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Apr 24 '24 19:04 github-actions[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Apr 25 '24 05:04 github-actions[bot]

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.87% (34346/52948) 42.04% (13551/32235) 43.57% (4228/9704)

github-actions[bot] avatar Apr 25 '24 05:04 github-actions[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Apr 25 '24 10:04 github-actions[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Apr 25 '24 19:04 github-actions[bot]

@chirag-madlani @karanh37 changes made as per commets!

Ashish8689 avatar Apr 27 '24 18:04 Ashish8689