OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

FIX #16005 - database & databaseSchema should not be stored in table_entity json (#16005)

Open zjffdu opened this issue 10 months ago • 4 comments

Describe your changes:

Fixes 16005, make the following changes

  1. Update TableRepository to unset databaseSchema & database before storing.
  2. Update DatabaseSchemaRepository to unset database before storing.

The reason is that those relationship should be stored in entity_relationship.

Type of change:

  • [x] Bug fix
  • [ ] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My PR title is Fixes <issue-number>: <short explanation>
  • [x] I have commented on my code, particularly in hard-to-understand areas.

zjffdu avatar Apr 24 '24 04:04 zjffdu

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Apr 24 '24 04:04 github-actions[bot]

Thanks for the quick fix @zjffdu

harshach avatar Apr 24 '24 04:04 harshach

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Apr 24 '24 04:04 github-actions[bot]

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 08 '24 06:05 sonarqubecloud[bot]