OpenMetadata
OpenMetadata copied to clipboard
chore: address remarks after openlineage connector review
Describe your changes:
Fixes
I worked on addressing post-review remarks because the code should be further improved
Type of change:
- [ ] Bug fix
- [x] Improvement
- [ ] New feature
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation
Checklist:
- [x] I have read the CONTRIBUTING document.
- [ ] My PR title is
Fixes <issue-number>: <short explanation>
- [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
Hi there 👋 Thanks for your contribution!
The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test
, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.
Let us know if you need any help!
The Python checkstyle failed.
Please run make py_format
and py_format_check
in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.
You can install the pre-commit hooks with make install_test precommit_install
.
Quality Gate passed for 'open-metadata-ingestion'
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
88.8% Coverage on New Code
0.0% Duplication on New Code
converting to draft until https://github.com/OpenLineage/OpenLineage/tree/python/generate-facets-code is merged and we can leverage official OpenLineage models
converting to draft until https://github.com/OpenLineage/OpenLineage/tree/python/generate-facets-code is merged and we can leverage official OpenLineage models
hi @mgorsk1 is this ready to be picked up?
@pmbrull not yet, we are waiting for new OL client which will support proper models there, so we don't reinvent the wheel here. This is the PR to observe 👀 https://github.com/OpenLineage/OpenLineage/pull/2520