OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

chore: address remarks after openlineage connector review

Open mgorsk1 opened this issue 11 months ago • 14 comments

Describe your changes:

Fixes

I worked on addressing post-review remarks because the code should be further improved

Type of change:

  • [ ] Bug fix
  • [x] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

mgorsk1 avatar Mar 12 '24 08:03 mgorsk1

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 08:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 08:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 08:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 08:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 08:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 09:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 09:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 18:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 12 '24 21:03 github-actions[bot]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Mar 13 '24 06:03 github-actions[bot]

converting to draft until https://github.com/OpenLineage/OpenLineage/tree/python/generate-facets-code is merged and we can leverage official OpenLineage models

mgorsk1 avatar Mar 14 '24 12:03 mgorsk1

converting to draft until https://github.com/OpenLineage/OpenLineage/tree/python/generate-facets-code is merged and we can leverage official OpenLineage models

hi @mgorsk1 is this ready to be picked up?

pmbrull avatar Apr 08 '24 08:04 pmbrull

@pmbrull not yet, we are waiting for new OL client which will support proper models there, so we don't reinvent the wheel here. This is the PR to observe 👀 https://github.com/OpenLineage/OpenLineage/pull/2520

mgorsk1 avatar Apr 08 '24 09:04 mgorsk1