OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fixes #15266: added 'restart: always' to docker-compose files

Open sandervanlaar opened this issue 1 year ago • 9 comments

Describe your changes:

Fixes #15266 I updated the docker-compose files with the setting 'restart: always' for the containers that did not already have this setting. This ensures automatic start of the containers after rebooting a server.

The change was tested by:

  1. updating the docker-compose files (for mssql and progesql),
  2. running the command docker compose -f .\docker-compose-postgres.yml up --detach

Result: Four containers are running (ingestion, openmetadata_server, elasticsearch, postgresql). If Docker Desktop has the setting 'General > Start Docker Desktop when you sign in to your computer', all four containers will automatically start.

Type of change:

  • [x] Bug fix
  • [ ] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

sandervanlaar avatar Feb 20 '24 13:02 sandervanlaar

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Feb 20 '24 13:02 github-actions[bot]

Hi @sandervanlaar. Thank you for the contribution. LGTM 🚀

Could you also add restart: Always in docker-compose-ingestion.yml as well in this PR. Thanks.

akash-jain-10 avatar Feb 20 '24 13:02 akash-jain-10

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Feb 20 '24 14:02 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Feb 20 '24 15:02 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 03 '24 07:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 10 '24 07:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Mar 20 '24 14:03 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar Apr 11 '24 07:04 github-actions[bot]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] avatar May 23 '24 12:05 github-actions[bot]