open-life-science.github.io icon indicating copy to clipboard operation
open-life-science.github.io copied to clipboard

Contrast errors in people page

Open bebatut opened this issue 3 years ago • 10 comments
trafficstars

I ran Wave to check for accessibility on the website. In the people pages, I got many errors because of contrast in the people information:

image

It would be good to fix them

bebatut avatar Oct 10 '22 14:10 bebatut

I want to work on this! I am kinda confused.... What do you mean by contrast here ? Thanks for clarifying @bebatut

baimamboukar avatar Oct 10 '22 20:10 baimamboukar

It seems that some components in the page have really low contrast, which make them hard to be seen. You can install the wave extension in your browser and activate it on the people page to see where these components are in order to fix them

bebatut avatar Oct 11 '22 07:10 bebatut

Thanks for the clarifications! I will soon raise a pull request about this....☄️

baimamboukar avatar Oct 11 '22 07:10 baimamboukar

It seems that some components in the page have really low contrast, which make them hard to be seen. You can install the wave extension in your browser and activate it on the people page to see where these components are in order to fix them

Okay, I found a nice color that could get the contrast issue to sit better. @bebatut is there a specific CSS file that needs updating for the contrast issue to be resolved? Screenshot from 2022-10-11 22-37-55

Njong392 avatar Oct 11 '22 21:10 Njong392

@baimamboukar can i work with you on this if still avaliable, please DM me on the slack page @Lisa omojevwe

lisaomoh101 avatar Oct 13 '22 14:10 lisaomoh101

@baimamboukar can i work with you on this if still avaliable, please DM me on the slack page @Lisa omojevwe

Hello @lisaomoh101...

Yes it is still available ☄️

baimamboukar avatar Oct 13 '22 14:10 baimamboukar

@baimamboukar can i work with you on this if still avaliable, please DM me on the slack page @lisa omojevwe

@lisa User Notification

Hello! You're receiving this notice because you've tagged me, @lisa, on GitHub, likely in error. Lisa is a common first name, and happens to be mine. I use the @lisa username here on GitHub. While being tagged in various repositories is an interesting way for me to discover new projects, it's likely not your intention. Did you mean to tag someone else? Did you mean to use @lisa instead, in a word as word usage?

Next Steps

I'm unsubscribing from this issue, pull request or project so if you meant to tag someone else to notify them, I would recommend that. If you meant to use my user ID as a plain string, without having GitHub notify me, you can do so by wrapping with backticks (the ` character), like so: @lisa.

lisa avatar Oct 13 '22 18:10 lisa

hello @baimamboukar have you figured this issue out yet

Munnachienyi avatar Oct 15 '22 10:10 Munnachienyi

Hey everyone! If this hasn't been done (I couldn't find a PR for this), I think using the same green (#265F3F) as in PR#430 might fix it.

Since there seems to be no movement on this I'll give this a go, if anyone is working on it, please let me know 🙂

vasconsaurus avatar Oct 22 '22 18:10 vasconsaurus

actually, the solution in PR#430 also fixes this one, since the variable dark-green was changed

vasconsaurus avatar Oct 22 '22 18:10 vasconsaurus

Closing this issue as out of date. Thanks all! :)

yochannah avatar Jul 23 '24 19:07 yochannah