planet icon indicating copy to clipboard operation
planet copied to clipboard

all: Upgrade buttons to MDC component spec (connects #9166)

Open paulbert opened this issue 2 months ago â€ĸ 8 comments

So far ran the automatic script just on the first page of voices the layout is all over the place. It'll take a bit more work to fix this.

image

paulbert avatar Oct 02 '25 15:10 paulbert

On the resources page alignment got funky:

image

paulbert avatar Oct 09 '25 16:10 paulbert

X on the shelf is misaligned:

image

paulbert avatar Oct 09 '25 16:10 paulbert

Generally the icon button is overflowing some of the cards and tables (this is from courses list):

image

paulbert avatar Oct 09 '25 16:10 paulbert

I think this is ready for review. The resources issue above exists on the main branch so I made an issue for that #9250. The X and triple dot icon issues don't feel breaking to me. I'll see if I can fix them but it'd be good to get another review on this in case there are more pressing layout issues that I'm missing.

paulbert avatar Oct 21 '25 19:10 paulbert

  • [x] Language select & profile image

The language select button text is off alignment as well, and the profile image has a weird cutoff that isn't there when it's just the icon: image

On master the profile image looks like this: image

  • [x] Eye icon in the login dialog

The eye input overflows: image

  • [x] myDashboard close icon

Feels a little bit too big than it was and is much closer to the border: image

  • [x] Teams/Enterprises buttons

Request to join button icon is cutoff image

-> Generally icon buttons are noticeably smaller/thinner

  • [x] Chat sidebar controls

new chat & close sidebar buttons alignment: image

similarly, the open drawer alignment is wider at the bottom: image

  • [x] Run sync button alignment
image
  • [x] AI configurations

API keys inline icons are zoomed: image

  • [x] achievements buttons alignment
image
  • [x] Change password eye icon
image
  • [x] Edit team/enterprise/course icon looks extended
image
  • [x] Courses: View resources button alignment
image

Mutugiii avatar Oct 23 '25 15:10 Mutugiii

Not sure if these selectors should be updated as well

  • src/app/surveys/surveys.component.scss:39,55,76 - button[mat-raised-button]
  • src/app/login/login.scss:54 - button[mat-raised-button]
  • src/app/teams/teams.scss:35,82 - button[mat-raised-button]
  • src/app/users/users-table.scss:34,50 - button[mat-raised-button]

Mutugiii avatar Nov 14 '25 20:11 Mutugiii

Not sure if these selectors should be updated as well

* src/app/surveys/surveys.component.scss:39,55,76 - button[mat-raised-button]

* src/app/login/login.scss:54 - button[mat-raised-button]

* src/app/teams/teams.scss:35,82 - button[mat-raised-button]

* src/app/users/users-table.scss:34,50 - button[mat-raised-button]

Good question. I'll check if they're used after the change and remove them if not.

paulbert avatar Nov 17 '25 17:11 paulbert

@Mutugiii Those styles look like they're being applied and they're the same size and position as the current app

paulbert avatar Nov 19 '25 17:11 paulbert

@codex review

Saby-Bishops avatar Nov 24 '25 21:11 Saby-Bishops

Codex Review: Didn't find any major issues. Delightful!

â„šī¸ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".