og-aws icon indicating copy to clipboard operation
og-aws copied to clipboard

broken link fix

Open eslerm opened this issue 3 years ago • 4 comments

eslerm avatar Mar 20 '22 05:03 eslerm

Hi @darigovresearch

Can you check https://github.com/open-guides/og-aws/pull/799/files? Line 1814 needs to be joined with line 1815 with the domain name added.

Looks like this on the readme currently: https://github.com/open-guides/og-aws#cloudformation-alternatives-and-lock-in

eslerm avatar Aug 13 '22 17:08 eslerm

@eslerm you can update your pull request to make the update you want, you can do that by clicking on the three dots then Edit file on the Files changed tab. Maybe it would be best to do an indented bullet point rather than merging the two into a bullet point like on line 1795.

image

Could you also clarify what you mean by ... with the domain name added?

All URLs in your changes appear to work and have their domains

darigovresearch avatar Aug 13 '22 19:08 darigovresearch

The original patch is as intended.

I will wait for projects maintainers to review.

eslerm avatar Aug 13 '22 21:08 eslerm

@eslerm sounds good.

Do any maintainers require anything else for this pull request to be merged?

darigovresearch avatar Sep 11 '22 07:09 darigovresearch