jak-project icon indicating copy to clipboard operation
jak-project copied to clipboard

[runtime] quick screenshot button

Open ManDude opened this issue 2 years ago • 8 comments

F8? F2? Any ideas?

ManDude avatar Aug 16 '22 01:08 ManDude

Steam screenshot button is f12, so I don't know if it would be better to use that or not considering that some people run the game as a non steam game. f8 makes sense to me as an in-game screenshot function, but then again such a thing may be entirely unneeded considering that most GUI operating systems come with or can be configured to have a screenshot feature.

RandomPrimary2004 avatar Aug 16 '22 01:08 RandomPrimary2004

F2/F3

Zedb0T avatar Aug 16 '22 01:08 Zedb0T

Whatever is picked can it be easily toggable until we have a proper UI to remap buttons. For example I have my AMD driver recording hotkeys setup to involve function keys.

xTVaser avatar Aug 16 '22 01:08 xTVaser

Should we just save the screenshot as what is set in the debug gui ("screenshot.png") or do we want it to do a steam style name + timestamp if you trigger it with the hotkey so you don't override it each screenshot?

sardap avatar Aug 16 '22 21:08 sardap

The debug GUI will eventually go away completely for normal users, so the filename would have to be something automatic. I really don't want to program an entirely new UI for this (and nobody else probably does either) so I think that's what we're gonna stick with on that aspect: hotkey and it just saves a screenshot to some user folder.

ManDude avatar Aug 16 '22 21:08 ManDude

I think "opengoal_YYYY_MM_DD_hh_mm_ss.png" does the job this does limit to one screenshot per second though.

For disabling screenshot with hotkey is a simple checkbox in the screenshot debug GUI menu acceptable? gk_Zka8MAlhS4

sardap avatar Aug 17 '22 11:08 sardap

Thinking about this more it really should be mappable though the existing control mapping UI I will try to get it working though that.

sardap avatar Aug 18 '22 08:08 sardap

I would replace opengoal with the actual game name, ie. jak1. That way we are future proofed for jak 2 and beyond, and opengoal is becoming a bit overloaded of a term.

https://github.com/open-goal/jak-project/blob/ead7f3415f97d1f120ec33be23e1acf343a6adb3/game/runtime.cpp#L71

xTVaser avatar Aug 19 '22 03:08 xTVaser