website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon open-gitops

feature: Add action to deploy previews on PR

Open niklasmtj opened this issue 2 years ago • 11 comments

This will enable the function of preview deployments when a PR is open and removes them when the PR is closed.

Should close #102

niklasmtj avatar Dec 06 '22 20:12 niklasmtj

PR Preview Action v1.2.0 :---: :rocket: Deployed preview to https://open-gitops.github.io/website/pr-preview/pr-106/ on branch gh-pages at 2022-12-06 20:57 UTC

github-actions[bot] avatar Dec 06 '22 20:12 github-actions[bot]

Well it seems that we have a hard redirect from https://open-gitops.github.io to https://opengitops.dev/ which means that we have to figure out if it is possible to host previews like that.

niklasmtj avatar Dec 06 '22 21:12 niklasmtj

I wonder if we could have a subdomain for this? Like preview.opengitops.dev? @todaywasawesome @scottrigby

christianh814 avatar Dec 15 '22 23:12 christianh814

We should fix any hard redirects. For the most part links are relative, at least it seems that way based on local dev

scottrigby avatar Dec 15 '22 23:12 scottrigby

I believe this is fixed with https://github.com/open-gitops/website/pull/105

todaywasawesome avatar Jan 18 '23 19:01 todaywasawesome

I will have a closer look into this in the next days. It still seems to be the case that the redirect is going against the regular opengitops.dev page but there should be a solution.

niklasmtj avatar Jan 18 '23 19:01 niklasmtj

I noticed this has been stalled waiting for reviews. Is this PR still relevant after #105 ?

williamcaban avatar Mar 13 '23 23:03 williamcaban

Hello, I just want to bring attention to the limits that the GitHub page has, we maybe don't hit this in the near term but it is something to consider https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#usage-limits

cc @scottrigby

cpanato avatar May 10 '23 07:05 cpanato