standard icon indicating copy to clipboard operation
standard copied to clipboard

feat: add signature action to tx button spec

Open defispartan opened this issue 1 year ago • 2 comments

Add documentation for signature frames as an extension of tx button action.

Additionally, this PR adds two additional fields to untrustedData payload which are used in the tx button lifecycle:

  • address : connected wallet address
  • transactionId : transaction hash or signed typed data

defispartan avatar Jul 19 '24 01:07 defispartan

FWIW XMTP also has been playing around with signature frames. We just shoved the signature into the transactionId to avoid compatibility issues, which is not beautiful but does maintain compatibility.

Think I'm in complete agreement with @stephancill

neekolas avatar Jul 25 '24 21:07 neekolas

Thanks for the feedback @stephancill @neekola. I think that makes sense to keep using transactionId to avoid a breaking change here, updated the PR.

defispartan avatar Jul 31 '24 03:07 defispartan

@neekolas looks good to go if you're happy!

stephancill avatar Sep 06 '24 15:09 stephancill

Hello, any foreseeable ETA for this?

lusorio avatar Sep 12 '24 07:09 lusorio