java-sdk icon indicating copy to clipboard operation
java-sdk copied to clipboard

Move multi-provider into SDK

Open toddbaert opened this issue 6 months ago • 8 comments

[multi-provider] Move multi-provider into SDK

The multi-provider in the contrib repo should be moved into the SDK.

Requirements:

  • multi-provider is moved from contribs into SDK
  • multi-provider deprecated/removed in the contribs (@toddbaert @beeme1mr or @aepfli can help with this)
  • optionally, there may be simplifications than can be done once the multi-provider has access to SDK internals

Note:

  • the multi-provider should be marked as experimental for now, using in-line docs.

toddbaert avatar Jun 19 '25 12:06 toddbaert

Hey I'd like to work on this!

suvaidkhan avatar Jun 23 '25 05:06 suvaidkhan

Let us know if you have any issues, @suvaidkhan !

chrfwow avatar Jun 23 '25 06:06 chrfwow

Let us know if you have any issues, @suvaidkhan !

In the contrib implementation the initialize method of multiprovider creates a JSON blob to store the metadata info. And uses the following dependency -

<dependency>
            <groupId>org.json</groupId>
            <artifactId>json</artifactId>
            <version>20250517</version>
  </dependency>

Should I add the same dependency to the SDK as well?

suvaidkhan avatar Jun 27 '25 07:06 suvaidkhan

The first question would be: Do we already have another JSON library within our codebase that we might want to use? If not, I think it is feasible to add it. But in general we want to keep our dependencies in the SDK as limited as possible

aepfli avatar Jun 27 '25 10:06 aepfli

Quick question @aepfli and @chrfwow should I add the Multiprovider documentation in the providers section or create a new section?

suvaidkhan avatar Jun 27 '25 23:06 suvaidkhan

I would say to nest it under the provider section, but I have no strong feelings either way

chrfwow avatar Jun 30 '25 09:06 chrfwow

@chrfwow just realized this change has not been implemented in all the SDKs should I be making the change in the spec now or are we holding off till all are merged?

suvaidkhan avatar Jul 01 '25 08:07 suvaidkhan

I would say just go on, we will change the spec seperately. @toddbaert ?

chrfwow avatar Jul 01 '25 08:07 chrfwow

@chrfwow I see there is no update on this since long. I am a first contributor and am interested to work on this

Vishalup29 avatar Nov 29 '25 09:11 Vishalup29

@Vishalup29 thanks, I assigned the issue to you. Reach out if you need anything!

chrfwow avatar Dec 01 '25 07:12 chrfwow