go-sdk icon indicating copy to clipboard operation
go-sdk copied to clipboard

feat: Implement domain scoping

Open gunishmatta opened this issue 10 months ago • 5 comments

This PR

  • Adds Domain Scoping

Related Issues

Fixes #257

Notes

Follow-up Tasks

How to test

gunishmatta avatar Mar 30 '24 11:03 gunishmatta

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.74%. Comparing base (266cfc0) to head (37fa69a).

:exclamation: Current head 37fa69a differs from pull request most recent head 012a941

Please upload reports for the commit 012a941 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   81.91%   81.74%   -0.17%     
==========================================
  Files          10       10              
  Lines         962      964       +2     
==========================================
  Hits          788      788              
- Misses        154      156       +2     
  Partials       20       20              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 02 '24 22:04 codecov[bot]

Hi Team @beeme1mr @Kavindu-Dodan Thanks for your valuable feedback, Please give me a couple of days, I am out for a vacation, I will update the PR as soon as I get time.

gunishmatta avatar Apr 04 '24 18:04 gunishmatta

@gunishmatta really nice work 🙌 could you please check the minor changes I proposed? They should be easy to complete and once done I think this is ready

Kavindu-Dodan avatar Apr 25 '24 20:04 Kavindu-Dodan

Hi @Kavindu-Dodan / @beeme1mr I am done with the changes, please merge if looks good.

gunishmatta avatar May 05 '24 13:05 gunishmatta

I'll review this tomorrow. Thanks!

toddbaert avatar May 08 '24 18:05 toddbaert