go-sdk
go-sdk copied to clipboard
feat: Implement domain scoping
This PR
- Adds Domain Scoping
Related Issues
Fixes #257
Notes
Follow-up Tasks
How to test
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.74%. Comparing base (
266cfc0
) to head (37fa69a
).
:exclamation: Current head 37fa69a differs from pull request most recent head 012a941
Please upload reports for the commit 012a941 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## main #261 +/- ##
==========================================
- Coverage 81.91% 81.74% -0.17%
==========================================
Files 10 10
Lines 962 964 +2
==========================================
Hits 788 788
- Misses 154 156 +2
Partials 20 20
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi Team @beeme1mr @Kavindu-Dodan Thanks for your valuable feedback, Please give me a couple of days, I am out for a vacation, I will update the PR as soon as I get time.
@gunishmatta really nice work 🙌 could you please check the minor changes I proposed? They should be easy to complete and once done I think this is ready
Hi @Kavindu-Dodan / @beeme1mr I am done with the changes, please merge if looks good.
I'll review this tomorrow. Thanks!