flagd icon indicating copy to clipboard operation
flagd copied to clipboard

feat: improve error log and add flag disabled handling for ofrep

Open Kavindu-Dodan opened this issue 1 year ago • 2 comments

This PR

  • Handle FlagDisabledErrorCode and include a specific error message along with general error code
  • Improve error message for targeting rule validation failure

Kavindu-Dodan avatar May 09 '24 16:05 Kavindu-Dodan

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
Latest commit 738a69abdb25052d06c24b9f1932b7bd3afff1b2
Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/663d2e6441791c00088eb38d

netlify[bot] avatar May 09 '24 16:05 netlify[bot]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.31%. Comparing base (1c530ab) to head (738a69a). Report is 59 commits behind head on main.

Files Patch % Lines
core/pkg/evaluator/json.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
+ Coverage   73.69%   77.31%   +3.61%     
==========================================
  Files          32       20      -12     
  Lines        3140     1622    -1518     
==========================================
- Hits         2314     1254    -1060     
+ Misses        717      286     -431     
+ Partials      109       82      -27     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 19:05 codecov[bot]