dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

chore: Cleanup .props file

Open askpt opened this issue 7 months ago • 1 comments

Signed-off-by: André Silva [email protected]

This PR

This pull request introduces several changes to improve project configuration and clean up unused code. The most significant updates include enabling implicit usings globally, removing redundant Nullable and ImplicitUsings properties from specific project files, and cleaning up unused using directives across multiple source files.

Project configuration improvements:

  • Enabled ImplicitUsings globally in build/Common.props to streamline code and reduce boilerplate. Removed redundant TreatWarningsAsErrors configuration for the Release build. [1] [2]
  • Added conditional Using directives for test projects in build/Common.tests.props, ensuring proper dependencies for E2E tests.

Code cleanup:

  • Removed redundant Nullable and ImplicitUsings properties from OpenFeature.DependencyInjection.csproj and OpenFeature.Hosting.csproj as these are now handled globally. [1] [2]
  • Cleaned up unused using directives across multiple source files, including Api.cs, AsyncLocalTransactionContextPropagator.cs, and various exception classes, to improve readability and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]

askpt avatar May 19 '25 15:05 askpt

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.08%. Comparing base (9742a0d) to head (2e5be34). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files          45       45           
  Lines        1757     1757           
  Branches      184      184           
=======================================
  Hits         1530     1530           
  Misses        187      187           
  Partials       40       40           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 19 '25 15:05 codecov[bot]