dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard
verified publisher icon open-feature

Review requirement IDs used in tests

Open beeme1mr opened this issue 1 year ago • 3 comments

Requirements

The requirement IDs used in the specification changed when we added support for client-side feature flags. The .NET SDK uses those IDs in some tests. These should be reviewed to make sure they match the spec.

Requirements that are out of date:

  • dotnet-sdk/test/OpenFeature.Tests/OpenFeatureClientTests.cs
    • Spec IDs: 1.4.5-1.4.14
  • dotnet-sdk/test/OpenFeature.Tests/OpenFeatureHookTests.cs
    • Spec IDs: 4.3.3-4.3.8

Here's the diff between spec v0.5.2 and v0.8.0.

beeme1mr avatar Jan 23 '24 18:01 beeme1mr

The evaluation context also lacks the required 'targeting key` field

https://github.com/open-feature/dotnet-sdk/blob/2c237df6e0ad278ddd8a51add202b797bf81374e/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs#L46

roelofb avatar Feb 04 '24 20:02 roelofb

@roelofb excellent catch! I've created a bug for this: https://github.com/open-feature/dotnet-sdk/issues/230

toddbaert avatar Feb 06 '24 16:02 toddbaert

@toddbaert Added a PR: #231

roelofb avatar Feb 07 '24 09:02 roelofb