dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

feat: Add OpenFeature.Extensions.Hosting package

Open austindrenski opened this issue 1 year ago • 4 comments

Closes: open-feature/dotnet-sdk#264


Related

  • open-feature/spec#81
    • open-feature/ofep#32
    • open-feature/spec#227

TODO:

  • [ ] moar tests
    • [ ] evaluation context
      • [ ] IHostingEnvironment sample
    • [ ] hooks
    • [ ] providers:
      • [ ] none
      • [ ] one
      • [ ] multiple
  • [ ] xml docs
  • [ ] readme docs

austindrenski avatar Jan 16 '24 22:01 austindrenski

Codecov Report

Attention: Patch coverage is 65.78947% with 39 lines in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (11a0333) to head (bcf19c4). Report is 11 commits behind head on main.

:exclamation: Current head bcf19c4 differs from pull request most recent head 9daa33f

Please upload reports for the commit 9daa33f to get more accurate results.

Files Patch % Lines
...Extensions.Hosting/OpenFeatureBuilderExtensions.cs 58.10% 29 Missing and 2 partials :warning:
src/Shared/CallerArgumentExpressionAttribute.cs 0.00% 5 Missing :warning:
src/Shared/Check.cs 66.66% 1 Missing and 1 partial :warning:
...sions.Hosting/Internal/OpenFeatureHostedService.cs 93.75% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   95.40%   90.82%   -4.59%     
==========================================
  Files          27       29       +2     
  Lines        1111     1068      -43     
  Branches      120      113       -7     
==========================================
- Hits         1060      970      -90     
- Misses         34       70      +36     
- Partials       17       28      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 17 '24 16:01 codecov[bot]

FYI couple of known test failures:

  1. [x] ~~DCO is intentionally broken by a temp commit containing a squash of #187 and #188. Once those PRs are merged, I'll rebase and elide the temp commit.~~
  2. [x] dotnet-format is being weird about OpenFeatureHostedService and I'm pretty sure its just a sign that we need to migrate from the dotnet-format tool, to the new dotnet format that's baked into recent SDKs.
  3. [x] ~~flaky unit tests: pretty sure these are all related to the async stuff, so hoping they'll be less common after open-feature/dotnet-sdk-contrib#184 lands, but in the meantime please just re-run the test if its failed at the time of your review.~~

austindrenski avatar Jan 17 '24 16:01 austindrenski

Is this PR going to be merged? I was looking forward to this capabilities with version 2.0

nbr28 avatar Sep 24 '24 18:09 nbr28

Is this PR going to be merged? I was looking forward to this capabilities with version 2.0

@nbr28 This is still being worked on, mostly by @askpt :pray: . We are still planning to merge once it's completed.

toddbaert avatar Sep 25 '24 12:09 toddbaert

Superseded by #310

askpt avatar Oct 14 '24 06:10 askpt