dotnet-sdk-contrib icon indicating copy to clipboard operation
dotnet-sdk-contrib copied to clipboard

feat: Introduce flipt provider for dotnet

Open jeandreidc opened this issue 1 year ago • 3 comments

Flipt.io provider for dotnet

Initial version of flipt.io provider for dotnet.

  • Created a new provider for OpenFeature for flipt.io in .net

Related Issues

None

Notes

  • Handles most of openFeature datatypes

Follow-up Tasks

  • [x] Pending unit tests for FliptProvider.cs class
  • [x] Support .net 6.0, right now it only supports .net 8.0

jeandreidc avatar Sep 27 '24 18:09 jeandreidc

Updated @markphelps

jeandreidc avatar Oct 03 '24 23:10 jeandreidc

@jeandreidc Great work! Thanks a lot. There's only 3 small things blocking my approval:

toddbaert avatar Oct 04 '24 17:10 toddbaert

Thanks again @jeandreidc !! Looks great!

cc @toddbaert

markphelps avatar Oct 08 '24 17:10 markphelps

@beeme1mr @toddbaert is there anything else blocking this from merge?

Thanks again @jeandreidc !!

markphelps avatar Oct 14 '24 20:10 markphelps

Approved, but there's an issue with the build. Feel free to ping me so I can retrigger CI once the issue has been addressed.

beeme1mr avatar Oct 14 '24 20:10 beeme1mr

Fixed the build issue please re-run the workflows, TIA! @beeme1mr

jeandreidc avatar Oct 14 '24 22:10 jeandreidc

Hello @beeme1mr was it merged by mistake? I was waiting for the build pipeline to pass

jeandreidc avatar Oct 14 '24 23:10 jeandreidc

Yes, I thought the tests passed but apparently they hadn't started.

beeme1mr avatar Oct 14 '24 23:10 beeme1mr

@jeandreidc sorry about that. ~~Would you mind addressing the build issue in a separate pr? On the bright side, the ci should run automatically since it's no longer your first contribution~~ 😀

We're going to revert the merge. Could you please open a new PR referencing this one?

beeme1mr avatar Oct 14 '24 23:10 beeme1mr