dotnet-sdk-contrib icon indicating copy to clipboard operation
dotnet-sdk-contrib copied to clipboard

Move all (most?) dependency versions out of `Common.prod.props`?

Open toddbaert opened this issue 1 year ago • 1 comments

Since this is a monorepo to support various contributions (providers, hooks, framework-specific integrations) we should try to decentralize dependency management as much as possible (move dependencies into the subfolder belonging to the associated module). This is especially important to make optimal use of both release-please and the component_owners configuration. The OpenFeature SDK dependency as well as any module-specific dependencies should be maintained by each module. Some basic common modules and test modules may be centrally maintained if that's valuable.

See: https://github.com/open-feature/dotnet-sdk-contrib/pull/136#pullrequestreview-1827964995, https://github.com/open-feature/dotnet-sdk-contrib/pull/136#discussion_r1465316395

Originally posted by @austindrenski in https://github.com/open-feature/dotnet-sdk-contrib/issues/136#issuecomment-1908617863

toddbaert avatar Jan 25 '24 19:01 toddbaert

I had a quick look at this and am happy to give it a go. What I can see needs to be done is:

  • Remove this line and add the reference directly to the individual projects
  • (Optional) Rework this section to potentially push some test dependencies down to individual projects, and to reference the version directly in the rest, so renovate can do it's work on updating them.

jenshenneberg avatar Jun 24 '24 21:06 jenshenneberg

@jenshenneberg are you still working on this PR?

askpt avatar Apr 21 '25 15:04 askpt