anomalib icon indicating copy to clipboard operation
anomalib copied to clipboard
verified publisher icon open-edge-platform

🔨Fix the visualization issue of inference image

Open ABoLei opened this issue 3 years ago • 4 comments

Description

  • Fixes #289

  • Fix the visualization issue when the input image is smaller than the canvas of inference result

  • Instead of overlay the inference result(Confidence Score) on the prediction image, make the inference result as a separate line above the prediction image

  • The demonstration is as below:

  • input image size = 1443 * 1443 large

  • input image size = 900 * 900 000

  • input image size = 41 * 41 small

Changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist

  • [x] My code follows the pre-commit style and check guidelines of this project.
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing tests pass locally with my changes

ABoLei avatar Apr 29 '22 09:04 ABoLei

@samet-akcay Could you review this PR? thanks

ABoLei avatar May 06 '22 01:05 ABoLei

@ABoLei thank you for your PR. There has been some changes in the visualizer after this PR. Your PR would have some conflicts due to these changes? Can you check the development branch to see if the issue you reported still the case? If yes, we would update your PR based on the recent changes.

How does this sound?

samet-akcay avatar May 12 '22 10:05 samet-akcay

@ABoLei thank you for your PR. There has been some changes in the visualizer after this PR. Your PR would have some conflicts due to these changes? Can you check the development branch to see if the issue you reported still the case? If yes, we would update your PR based on the recent changes.

How does this sound?

Sure thing, I will check it later on,

ABoLei avatar May 13 '22 03:05 ABoLei

@samet-akcay I fixed the conflicts and remain the changes I made, please have a look, thanks

ABoLei avatar May 13 '22 07:05 ABoLei

This issue is no longer present with the latest version of the visualizer.

djdameln avatar Sep 02 '22 09:09 djdameln